This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Add a validate_cmd to config file resource #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rue on a dropwizard::instance
|
On further reflection I've also made the addition of a It also allows for reloading of configs to be handled in application to pick up changes automatically and not require a JVM / service restart. |
|
It looks like the latest 2.1.0 vesion of puppetlabs-java is being pulled in for tests and is only valid for Puppet 4. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Tron,
Awesome module! I ran into a problem lately where deploying a config change caused services to fail at restart but Puppet to carry on happily and Jenkins to deploy these changes throughout the (non-production) environments with no problem.
We could be a bit more defensive and validate the file before it gets copied in place using the Dropwizard check command. I've added the ability to enable / disable this by setting
$config_teston thedropwizard::instanceyou want to check.On reflection I think that
Restart=on-failurein the systemd unit might be a part of the problem too. MaybeRestart=on-abnormalwould be a better option so that if the Dropwizard server command fails to start and exits != 0 Puppet should (might) pick up this failure?Any feedback would be greatly appreciated.
Thanks,
Tim.